Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

Issue 2058133002: Fix DevTools support of worklets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved MainThreadDebugger::callingContextCanAccessContext's logic to BindingSecurity Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
index ba696d11f440bc4c8a593d0f3622e2d1c033b608..993be3d991d416f9ca0f628d41138c9a78c1c927 100644
--- a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
+++ b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
@@ -32,6 +32,7 @@
#define BindingSecurity_h
#include "core/CoreExport.h"
+#include "core/dom/ExecutionContext.h"
Yuki 2016/06/29 00:30:37 Could you use a forward declaration instead? clas
Gleb Lanbin 2016/06/29 17:07:13 Done.
#include "wtf/Allocator.h"
#include <v8.h>
@@ -72,7 +73,9 @@ public:
static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Location* target, ExceptionState&);
static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Location* target, SecurityReportingOption);
// MainThreadWorkletGlobalScope
- static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const MainThreadWorkletGlobalScope* target, SecurityReportingOption);
+ static bool shouldAllowAccessTo(v8::Isolate*, const v8::Local<v8::Context>&, const ExecutionContext*, const MainThreadWorkletGlobalScope* target, SecurityReportingOption);
Yuki 2016/06/29 00:30:37 I think const v8::Local<>& doesn't make much sen
Gleb Lanbin 2016/06/29 17:07:13 Done.
+
+ static bool shouldAllowAccessTo(v8::Isolate*, v8::Local<v8::Context> calling, v8::Local<v8::Context> target, SecurityReportingOption);
// Prefer to use the previous overloads instead of falling back to using
// Frame*.
static bool shouldAllowAccessToFrame(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Frame* target, SecurityReportingOption); // OBSOLETE

Powered by Google App Engine
This is Rietveld 408576698