Fix DevTools support of worklets

third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef BindingSecurity_h
 #define BindingSecurity_h
 
 #include "core/CoreExport.h"
+#include "core/dom/ExecutionContext.h"

[Yuki, 2016/06/29 00:30:37]

Could you use a forward declaration instead?

class ExecutionContext;

should be enough.

[Gleb Lanbin, 2016/06/29 17:07:13]

Done.

 #include "wtf/Allocator.h"
 #include <v8.h>
 
 namespace blink {
 
 class DOMWindow;
 class EventTarget;
 class ExceptionState;
 class Frame;
 class LocalDOMWindow;
@@ skipping 20 matching lines @@
     //
     // DOMWindow
     static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const DOMWindow* target, ExceptionState&);
     static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const DOMWindow* target, SecurityReportingOption);
     // EventTarget (as the parent of DOMWindow)
     static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const EventTarget* target, ExceptionState&);  // NOLINT(readability/parameter_name)
     // Location
     static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Location* target, ExceptionState&);
     static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Location* target, SecurityReportingOption);
     // MainThreadWorkletGlobalScope
-    static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const MainThreadWorkletGlobalScope* target, SecurityReportingOption);
+    static bool shouldAllowAccessTo(v8::Isolate*, const v8::Local<v8::Context>&, const ExecutionContext*, const MainThreadWorkletGlobalScope* target, SecurityReportingOption);

[Yuki, 2016/06/29 00:30:37]

I think
  const v8::Local<>&
doesn't make much sense.

Just use v8::Local<v8::Context> without a const reference.

[Gleb Lanbin, 2016/06/29 17:07:13]

Done.

+
+    static bool shouldAllowAccessTo(v8::Isolate*, v8::Local<v8::Context> calling, v8::Local<v8::Context> target, SecurityReportingOption);
     // Prefer to use the previous overloads instead of falling back to using
     // Frame*.
     static bool shouldAllowAccessToFrame(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Frame* target, SecurityReportingOption); // OBSOLETE
 
     // Check if the caller (|accessingWindow|) is allowed to access the JS
     // returned object (|target|), where the returned object is the JS object
     // which is returned as a result of invoking a DOM attribute or DOM
     // operation (in the form of
     //   var x = receiver.domAttr // or receiver.domOp()
     // where |x| is the returned object).
     // See window.frameElement for example, which may return a frame object.
     // The object returned from window.frameElement must be the same origin if
     // it's not null.
     //
     // Node
     static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Node* target, ExceptionState&);
     static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Node* target, SecurityReportingOption);
 };
 
 } // namespace blink
 
 #endif