third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp - Issue 2058133002: Fix DevTools support of worklets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Issue 2058133002: Fix DevTools support of worklets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move callingContextCanAccessContext to BindingSecurity Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/DEPS ('k') | third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

index 868fdeabb4a10bbbd26e5c896eed010b25383bb0..b736b3550711572b2ec77848ab44dd45e410dd58 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

@@ -30,6 +30,7 @@

#include "platform/v8_inspector/InjectedScript.h"

+#include "bindings/core/v8/BindingSecurity.h"

#include "platform/inspector_protocol/Parser.h"

#include "platform/inspector_protocol/String16.h"

#include "platform/inspector_protocol/Values.h"

@@ -276,7 +277,7 @@ bool InjectedScript::canAccessInspectedWindow() const

v8::Local<v8::Context> callingContext = m_context->isolate()->GetCallingContext();

if (callingContext.IsEmpty())

return true;

- return m_context->debugger()->client()->callingContextCanAccessContext(callingContext, m_context->context());

+ return BindingSecurity::callingContextCanAccessContext(m_context->debugger()->isolate(), callingContext, m_context->context(), DoNotReportSecurityError);

}

v8::Local<v8::Value> InjectedScript::v8Value() const