third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h - Issue 2058133002: Fix DevTools support of worklets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

Issue 2058133002: Fix DevTools support of worklets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move callingContextCanAccessContext to BindingSecurity Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

index d3227d099e552ddf79abcec8c15d90f1ccbbeba6..d7d4f5aeb37b9617a515cae72654ec1c5e617974 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

@@ -25,7 +25,6 @@ public:

virtual void unmuteConsole() = 0;

virtual void beginUserGesture() = 0;

virtual void endUserGesture() = 0;

- virtual bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) = 0;

dgozman 2016/06/28 18:31:14 Sorry, I wasn't clear here. We should live this me

Gleb Lanbin 2016/06/28 19:17:10 Done.

virtual String16 valueSubtype(v8::Local<v8::Value>) = 0;

virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) = 0;

virtual bool isExecutionAllowed() = 0;