Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2057913003: [BattOr] Do not catch exception when failing to start battor. (Closed)

Created:
4 years, 6 months ago by rnephew (Reviews Here)
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py View 1 chunk +6 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
rnephew (Reviews Here)
4 years, 6 months ago (2016-06-10 16:48:12 UTC) #2
charliea (OOO until 10-5)
non-owner lgtm
4 years, 6 months ago (2016-06-10 17:10:59 UTC) #3
nednguyen
lgtm
4 years, 6 months ago (2016-06-10 17:16:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057913003/1
4 years, 6 months ago (2016-06-10 17:19:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Mac%20Tryserver/builds/3514)
4 years, 6 months ago (2016-06-10 17:32:44 UTC) #8
rnephew (Reviews Here)
On 2016/06/10 17:32:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-10 17:48:39 UTC) #9
rnephew (Reviews Here)
On 2016/06/10 17:48:39, rnephew (Reviews Here) wrote: > On 2016/06/10 17:32:44, commit-bot: I haz the ...
4 years, 6 months ago (2016-06-14 14:26:43 UTC) #10
nednguyen
lgtm
4 years, 6 months ago (2016-06-14 14:41:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057913003/20001
4 years, 6 months ago (2016-06-14 15:27:14 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 15:51:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698