telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py - Issue 2057913003: [BattOr] Do not catch exception when failing to start battor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

Issue 2057913003: [BattOr] Do not catch exception when failing to start battor. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

diff --git a/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py b/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

index de2005ea873428cbd96d74757f43f217f1688e27..7d5d50f5e7c166427d8119d76cb2c749c3958a58 100644

--- a/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

+++ b/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

@@ -156,7 +156,8 @@ class BattOrTracingAgentTest(unittest.TestCase):

def throw_battor_error():

raise battor_error.BattorError('Forced Exception')

self.android_agent._battor.StartTracing = throw_battor_error

- self.assertFalse(self.android_agent.StartAgentTracing(self._config, 0))

+ with self.assertRaises(battor_error.BattorError):

+ self.android_agent.StartAgentTracing(self._config, 0)

def testStopAgentTracing(self):

self.android_agent.StopAgentTracing()

« no previous file with comments | « telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py ('k') | no next file » | no next file with comments »