Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing creis@'s comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index f6a25c17c6e18b7a5b83149f686ace8cda3fc7e5..756a7d834aa7155016516108d276c606b6723b6e 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -251,18 +251,27 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
cc::SurfaceId original_surface,
gfx::Point* transformed_point);
+ //----------------------------------------------------------------------------
+ // The following methods are related to IME.
+ // TODO(ekaramad): Most of the IME methods should not stay virtual after IME
+ // is implemented for OOPIF. After fixing IME, mark the corresponding methods
+ // non-virtual (https://crbug.com/578168).
+
// Updates the state of the input method attached to the view.
- // TODO(ekaramad): This method will not stay virtual. It will be moved up top
- // with the other non-virtual methods after TextInputState tracking is fixed
- // on all platforms (https://crbug.com/578168).
virtual void TextInputStateChanged(const TextInputState& text_input_state);
// Cancel the ongoing composition of the input method attached to the view.
- // TODO(ekaramad): This method will not stay virtual. It will be moved up top
- // with the other non-virtual methods after IME is fixed on all platforms.
- // (https://crbug.com/578168).
virtual void ImeCancelComposition();
+ // Notifies the view that the renderer selection bounds has changed.
+ // Selection bounds are described as a focus bound which is the current
+ // position of caret on the screen, as well as the anchor bound which is the
+ // starting position of the selection. The coordinates are with respect to
+ // RenderWidget's window's origin. Focus and anchor bound are represented as
+ // gfx::Rect.
+ virtual void SelectionBoundsChanged(
+ const ViewHostMsg_SelectionBounds_Params& params);
+
//----------------------------------------------------------------------------
// The following static methods are implemented by each platform.
@@ -299,13 +308,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// the page has changed.
virtual void SetTooltipText(const base::string16& tooltip_text) = 0;
- // Notifies the View that the renderer selection bounds has changed.
- // |start_rect| and |end_rect| are the bounds end of the selection in the
- // coordinate system of the render view. |start_direction| and |end_direction|
- // indicates the direction at which the selection was made on touch devices.
- virtual void SelectionBoundsChanged(
- const ViewHostMsg_SelectionBounds_Params& params) = 0;
-
// Copies the contents of the compositing surface, providing a new SkBitmap
// result via an asynchronously-run |callback|. |src_subrect| is specified in
// layer space coordinates for the current platform (e.g., DIP for Aura/Mac,

Powered by Google App Engine
This is Rietveld 408576698