content/browser/renderer_host/render_widget_host_view_base.cc - Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing creis@'s comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/renderer_host/text_input_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc

index 0b34ce08789a322dc1894a812d809c1ec9ffeab9..41724ead586ebe5c9461dbe00f581442d29d6601 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base.cc

@@ -102,6 +102,12 @@ float RenderWidgetHostViewBase::GetTopControlsHeight() const {

return 0.f;

}

+void RenderWidgetHostViewBase::SelectionBoundsChanged(

+ const ViewHostMsg_SelectionBounds_Params& params) {

+ if (GetTextInputManager())

+ GetTextInputManager()->SelectionBoundsChanged(this, params);

void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text,

size_t offset,

const gfx::Range& range) {

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/renderer_host/text_input_manager.h » ('j') | no next file with comments »