Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: content/public/test/text_input_test_utils.h

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed |selection_anchor_| and |selection_focus_| from RenderWidgetHostViewAura. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/text_input_test_utils.h
diff --git a/content/public/test/text_input_test_utils.h b/content/public/test/text_input_test_utils.h
index 92be4ae87b1d597854953b7c9aead9ef86219700..fbcd3fb0ccb15e110c3e2d100b59e3a9e492ab28 100644
--- a/content/public/test/text_input_test_utils.h
+++ b/content/public/test/text_input_test_utils.h
@@ -51,6 +51,10 @@ class TextInputManagerTester {
// on the TextInputManager which is being observed.
void SetUpdateTextInputStateCalledCallback(const Callback& callback);
+ // Sets a callback which is invoked when a RWHV calls SelectionBoundsChanged
+ // on the TextInputManager which is being observed.
+ void SetOnSelectionBoundsChangedCallback(const Callback& callback);
+
// Returns true if there is a focused <input> and populates |type| with
// |TextInputState.type| of the TextInputManager.
bool GetTextInputType(ui::TextInputType* type);
@@ -63,8 +67,8 @@ class TextInputManagerTester {
// if none exists.
const RenderWidgetHostView* GetActiveView();
- // Returns the RenderWidgetHostView which has most recently called
- // TextInputManager::UpdateTextInputState on the TextInputManager which is
+ // Returns the RenderWidgetHostView which has most recently updated its state,
+ // i.e., selection bounds or TextInputState, with the TextInputManager that is
Charlie Reis 2016/06/29 20:18:37 Are these the only things that will trigger it, or
EhsanK 2016/06/30 00:24:45 We might keep adding for similar additions: Render
Charlie Reis 2016/06/30 20:27:21 Updating the value on any of those seems reasonabl
EhsanK 2016/06/30 21:01:14 Acknowledged.
// being observed.
const RenderWidgetHostView* GetUpdatedView();

Powered by Google App Engine
This is Rietveld 408576698