Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only)

content/public/test/text_input_test_utils.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_TEXT_INPUT_TEST_UTILS_H_
 #define CONTENT_PUBLIC_TEST_TEXT_INPUT_TEST_UTILS_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 33 matching lines @@
  public:
   using Callback = base::Callback<void(TextInputManagerTester*)>;
 
   TextInputManagerTester(WebContents* web_contents);
   virtual ~TextInputManagerTester();
 
   // Sets a callback which is invoked when a RWHV calls UpdateTextInputState
   // on the TextInputManager which is being observed.
   void SetUpdateTextInputStateCalledCallback(const Callback& callback);
 
+  // Sets a callback which is invoked when a RWHV calls SelectionBoundsChanged
+  // on the TextInputManager which is being observed.
+  void SetOnSelectionBoundsChangedCallback(const Callback& callback);
+
   // Returns true if there is a focused <input> and populates |type| with
   // |TextInputState.type| of the TextInputManager.
   bool GetTextInputType(ui::TextInputType* type);
 
   // Returns true if there is a focused <input> and populates |value| with
   // |TextInputState.value| of the TextInputManager.
   bool GetTextInputValue(std::string* value);
 
   // Returns the RenderWidgetHostView with a focused <input> element or nullptr
   // if none exists.
   const RenderWidgetHostView* GetActiveView();
 
-  // Returns the RenderWidgetHostView which has most recently called
-  // TextInputManager::UpdateTextInputState on the TextInputManager which is
+  // Returns the RenderWidgetHostView which has most recently updated its state,
+  // i.e., selection bounds or TextInputState, with the TextInputManager that is

[Charlie Reis, 2016/06/29 20:18:37]

Are these the only things that will trigger it, or do we need to keep adding
reasons?

[EhsanK, 2016/06/30 00:24:45]

We might keep adding for similar additions:
RenderWidgetHostViewBase::SelectionChanged
RenderWidgetHostViewBase::ImeCompositionRangeChanged
are similar changes for their application in IME.

[Charlie Reis, 2016/06/30 20:27:21]

Updating the value on any of those seems reasonable.  That said, I'm not sure if
it's useful to have an exhaustive list in this comment, since it's likely to get
stale.  Changing this to "most recently updated any of its state (e.g.,
TextInputState or otherwise)" might be sufficient.

[EhsanK, 2016/06/30 21:01:14]

Acknowledged.

   // being observed.
   const RenderWidgetHostView* GetUpdatedView();
 
   // Returns true if a call to TextInputManager::UpdateTextInputState has led
   // to a change in TextInputState (since the time the observer has been
   // created).
   bool IsTextInputStateChanged();
 
  private:
   // The actual internal observer of the TextInputManager.
@@ skipping 68 matching lines @@
       const base::Closure& callback) = 0;
   virtual void SetOnShowImeIfNeededCallback(const base::Closure& callback) = 0;
 
  protected:
   TestInputMethodObserver();
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_TEXT_INPUT_TEST_UTILS_H_