Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed |selection_anchor_| and |selection_focus_| from RenderWidgetHostViewAura. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 1fb97586cdea0428fddddace86510fe4051597f1..b101e45386bde08bf62e9f075106471c9f8617d2 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -153,8 +153,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
size_t offset,
const gfx::Range& range) override;
gfx::Size GetRequestedRendererSize() const override;
- void SelectionBoundsChanged(
- const ViewHostMsg_SelectionBounds_Params& params) override;
void CopyFromCompositingSurface(
const gfx::Rect& src_subrect,
const gfx::Size& dst_size,
@@ -474,6 +472,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
bool did_update_state) override;
void OnImeCancelComposition(TextInputManager* text_input_manager,
RenderWidgetHostViewBase* updated_view) override;
+ void OnSelectionBoundsChanged(
+ TextInputManager* text_input_manager,
+ RenderWidgetHostViewBase* updated_view) override;
// cc::BeginFrameObserver implementation.
void OnBeginFrame(const cc::BeginFrameArgs& args) override;
@@ -584,11 +585,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// object.
ui::MotionEventAura pointer_state_;
- // Bounds for the selection.
- gfx::SelectionBound selection_anchor_;
- gfx::SelectionBound selection_focus_;
-
- // The current composition character bounds.
+ // The current composition character bounds.
Charlie Reis 2016/06/29 20:18:37 nit: Wrong indent.
EhsanK 2016/06/30 00:24:45 Sorry. Done.
std::vector<gfx::Rect> composition_character_bounds_;
// Indicates if there is onging composition text.

Powered by Google App Engine
This is Rietveld 408576698