content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed |selection_anchor_| and |selection_focus_| from RenderWidgetHostViewAura. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('K') | « chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | content/browser/renderer_host/render_widget_host_view_aura.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index e3a036176bbdbf690e3546a543b0b2c005d3fd63..d3cc7f2cdca0e7104c25ec2eb44b143b6eca0d42 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -299,6 +299,12 @@ void RenderWidgetHostViewChildFrame::SelectionChanged(

void RenderWidgetHostViewChildFrame::SelectionBoundsChanged(

const ViewHostMsg_SelectionBounds_Params& params) {

+ ViewHostMsg_SelectionBounds_Params transformed_params = params;

+ transformed_params.anchor_rect.set_origin(

+ TransformPointToRootCoordSpace(params.anchor_rect.origin()));

+ transformed_params.focus_rect.set_origin(

+ TransformPointToRootCoordSpace(params.focus_rect.origin()));

+ RenderWidgetHostViewBase::SelectionBoundsChanged(transformed_params);

}

void RenderWidgetHostViewChildFrame::LockCompositingSurface() {