SkPixmap::setColorSpace

SkPixmap::setColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057563002

[reed1, 2016-06-09 13:53:04]

Description was changed from

==========
SkPixmap::setColorSpace

BUG=skia:
==========

to

==========
SkPixmap::setColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057563002
==========

[reed1, 2016-06-09 13:53:53]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 13:54:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057563002/1

[reed1, 2016-06-09 13:59:17]

reed@google.com changed reviewers:
+ halcanary@google.com, msarett@google.com

[reed1, 2016-06-09 13:59:18]

This crashes on all_bitmap_configs when the backend is PDF. We seem to underflow
refcnts of SkColorSpace (i.e. unref too many times?)

Need help understanding where the bug is.

[commit-bot: I haz the power, 2016-06-09 14:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 14:00:55]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-06-09 14:03:15]

Line 39 in SkImageInfo.cpp seems to be the key. If I comment that out (i.e.
leave pt at the default) then we don't crash.

[hal.canary, 2016-06-09 14:13:44]

out/Debug/dm --config f16 --src gm -m dstreadshuffle

crashes for me.

[reed1, 2016-06-09 15:28:13]

On 2016/06/09 14:13:44, Hal Canary wrote:
> out/Debug/dm --config f16 --src gm -m dstreadshuffle
> 
> crashes for me.

I see an assert in float math, but nothing related to colorspaces. Do you see
something different? I also see this crash on TOT, w/o this CL.

[msarett, 2016-06-09 17:29:52]

I think this will help:
https://codereview.chromium.org/2052943002

https://codereview.chromium.org/2057563002/diff/1/src/core/SkPixmap.cpp
File src/core/SkPixmap.cpp (right):

https://codereview.chromium.org/2057563002/diff/1/src/core/SkPixmap.cpp#newco...
src/core/SkPixmap.cpp:56: fInfo = fInfo.makeColorSpace(cs);
nit: Could be std::move()?

[hal.canary, 2016-06-13 15:10:49]

Description was changed from

==========
SkPixmap::setColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057563002
==========

to

==========
SkPixmap::setColorSpace

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057563002
==========

[hal.canary, 2016-06-13 15:10:49]

halcanary@google.com changed reviewers:
- halcanary@google.com