Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 2052943002: SkPixmap::setColorSpace (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPixmap::setColorSpace Landed for reed@ with bug fix: Use default copy constructor for SkDraw BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057563002 patch from issue 2057563002 at patchset 1 (http://crrev.com/2057563002#ps1) Committed: https://skia.googlesource.com/skia/+/804b461bc4fe3cfd959fc065c1c0b524ef96e90b

Patch Set 1 #

Total comments: 2

Patch Set 2 : std::move() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M include/core/SkDraw.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageInfo.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkPixmap.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkImageInfo.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M src/core/SkPixmap.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
reed1
lgtm https://codereview.chromium.org/2052943002/diff/1/src/core/SkPixmap.cpp File src/core/SkPixmap.cpp (right): https://codereview.chromium.org/2052943002/diff/1/src/core/SkPixmap.cpp#newcode56 src/core/SkPixmap.cpp:56: fInfo = fInfo.makeColorSpace(cs); std::move
4 years, 6 months ago (2016-06-09 17:37:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052943002/20001
4 years, 6 months ago (2016-06-09 17:42:24 UTC) #6
msarett
https://codereview.chromium.org/2052943002/diff/1/src/core/SkPixmap.cpp File src/core/SkPixmap.cpp (right): https://codereview.chromium.org/2052943002/diff/1/src/core/SkPixmap.cpp#newcode56 src/core/SkPixmap.cpp:56: fInfo = fInfo.makeColorSpace(cs); On 2016/06/09 17:37:32, reed1 wrote: > ...
4 years, 6 months ago (2016-06-09 17:42:44 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 18:00:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052943002/20001
4 years, 6 months ago (2016-06-09 18:02:28 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 18:03:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/804b461bc4fe3cfd959fc065c1c0b524ef96e90b

Powered by Google App Engine
This is Rietveld 408576698