[wasm] Refactor function name table and lookup

[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Committed: https://crrev.com/759baaff7843622300991657fff21d1fe2ae76ca
Cr-Original-Commit-Position: refs/heads/master@{#36918}
Cr-Commit-Position: refs/heads/master@{#36952}

[titzer, 2016-06-10 13:21:41]

lgtm other than one nit

https://codereview.chromium.org/2057523002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2057523002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:985: Handle<Object> GetWasmFunctionNameOrNull(Isolate*
isolate, Handle<Object> wasm,
Why not require a Handle<JSObject> as input?

https://codereview.chromium.org/2057523002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:994: if (GetWasmFunctionNameFromTable(
The handle types can be simplified here a bit, I think.

e.g. Handle<ByteArray> func_names_arr_obj(ByteArray::cast(....)), isolate);

[Clemens Hammacher, 2016-06-13 08:51:35]

https://codereview.chromium.org/2057523002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2057523002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:985: Handle<Object> GetWasmFunctionNameOrNull(Isolate*
isolate, Handle<Object> wasm,
On 2016/06/10 13:21:40, titzer wrote:
> Why not require a Handle<JSObject> as input?

Because we also handle the undefined Object here, and return null or "<WASM
UNNAMED>" respectively.
Before, this check was done in the respective caller, but I remember Yang
complaining about this, he wanted us to pull all of this into wasm.

https://codereview.chromium.org/2057523002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:994: if (GetWasmFunctionNameFromTable(
On 2016/06/10 13:21:40, titzer wrote:
> The handle types can be simplified here a bit, I think.
> 
> e.g. Handle<ByteArray> func_names_arr_obj(ByteArray::cast(....)), isolate);

Done.

[Clemens Hammacher, 2016-06-13 09:29:37]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-06-13 09:29:37]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2057523002/#ps20001
(title: "minor fixes")

[commit-bot: I haz the power, 2016-06-13 09:29:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057523002/20001

[commit-bot: I haz the power, 2016-06-13 09:31:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 09:33:01]

Description was changed from

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org
==========

to

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Cr-Commit-Position: refs/heads/master@{#36918}
==========

[commit-bot: I haz the power, 2016-06-13 09:33:03]

Patchset 2 (id:??) landed as
https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Cr-Commit-Position: refs/heads/master@{#36918}

[Michael Achenbach, 2016-06-13 11:34:49]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2062793002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for flaky gc stress
crashes, e.g.:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds...
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20....

[Clemens Hammacher, 2016-06-13 13:10:49]

Description was changed from

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Cr-Commit-Position: refs/heads/master@{#36918}
==========

to

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Cr-Commit-Position: refs/heads/master@{#36918}
==========

[Clemens Hammacher, 2016-06-14 09:03:52]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-06-14 09:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2057523002/#ps40001
(title: "fix gc issue")

[commit-bot: I haz the power, 2016-06-14 09:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057523002/40001

[commit-bot: I haz the power, 2016-06-14 09:07:01]

Description was changed from

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Cr-Commit-Position: refs/heads/master@{#36918}
==========

to

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Cr-Commit-Position: refs/heads/master@{#36918}
==========

[commit-bot: I haz the power, 2016-06-14 09:07:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-14 09:07:52]

Description was changed from

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Cr-Commit-Position: refs/heads/master@{#36918}
==========

to

==========
[wasm] Refactor function name table and lookup

The function name table will now always be set; a CHECK will fail if
the length would exceed the integer range.
Also, the resolution of undefined function names to "<WASM UNNAMED>" is
moved over to the wasm side.

R=titzer@chromium.org

Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310
Committed: https://crrev.com/759baaff7843622300991657fff21d1fe2ae76ca
Cr-Original-Commit-Position: refs/heads/master@{#36918}
Cr-Commit-Position: refs/heads/master@{#36952}
==========

[commit-bot: I haz the power, 2016-06-14 09:07:53]

Patchset 3 (id:??) landed as
https://crrev.com/759baaff7843622300991657fff21d1fe2ae76ca
Cr-Commit-Position: refs/heads/master@{#36952}