Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2057493003:
[UseZoomForDSF:DevTools] Apply the zoom factor equivalent to device scale factor to overlay frame. (Closed)
DescriptionApply the zoom factor equivalent to device scale factor to overlay frame.
BUG=485650
TEST=manual
Committed: https://crrev.com/b4fde5673829b6dc3f181ceea6214bac0729cb55
Cr-Commit-Position: refs/heads/master@{#400767}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : Apply the zoom factor equivalent to device scale factor to overlay frame. #Messages
Total messages: 24 (12 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057493003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix inspector overlay BUG= ========== to ========== Fix inspector overlay BUG=485650 TEST=manual ==========
Description was changed from ========== Fix inspector overlay BUG=485650 TEST=manual ========== to ========== Apply the zoom factor equivalent to device scale factor to overlay frame. BUG=485650 TEST=manual ==========
oshima@chromium.org changed reviewers: + dgozman@chromium.org
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057493003/20001
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Why all these changes? Overlay page has the same size as the main page. Can't we just copy the values over? Also, is this always applied, or only in UseZoomForDFS mode? https://codereview.chromium.org/2057493003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/web/InspectorOverlay.cpp (right): https://codereview.chromium.org/2057493003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/web/InspectorOverlay.cpp:500: frame->setPageZoomFactor(windowToViewportScale); This should go to rebuildOverlayPage.
Patchset #2 (id:40001) has been deleted
On 2016/06/13 14:15:52, dgozman_slow wrote: > Why all these changes? Overlay page has the same size as the main page. It has the same size but has different devicePixelRatio because zoomFactor isn't copied, which this CL does. > Can't we > just copy the values over? I'm trying to copy the zoom factor as well. Please let me know if there is better way to do this. Thanks! https://codereview.chromium.org/2057493003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/web/InspectorOverlay.cpp (right): https://codereview.chromium.org/2057493003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/web/InspectorOverlay.cpp:500: frame->setPageZoomFactor(windowToViewportScale); On 2016/06/13 14:15:51, dgozman_slow wrote: > This should go to rebuildOverlayPage. Done.
Forgot to explain: > Also, is this always applied, or only in UseZoomForDFS mode? When UseZoomForDSF is disabled, windowToViewportScalar() returns the same value (thus 1.0f in this case), so this works in both cases.
Sorry for delay. lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057493003/60001
Message was sent while issue was closed.
Description was changed from ========== Apply the zoom factor equivalent to device scale factor to overlay frame. BUG=485650 TEST=manual ========== to ========== Apply the zoom factor equivalent to device scale factor to overlay frame. BUG=485650 TEST=manual ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Apply the zoom factor equivalent to device scale factor to overlay frame. BUG=485650 TEST=manual ========== to ========== Apply the zoom factor equivalent to device scale factor to overlay frame. BUG=485650 TEST=manual Committed: https://crrev.com/b4fde5673829b6dc3f181ceea6214bac0729cb55 Cr-Commit-Position: refs/heads/master@{#400767} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b4fde5673829b6dc3f181ceea6214bac0729cb55 Cr-Commit-Position: refs/heads/master@{#400767} |
