Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2057493003: [UseZoomForDSF:DevTools] Apply the zoom factor equivalent to device scale factor to overlay frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply the zoom factor equivalent to device scale factor to overlay frame. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index f88ab50db708e304dce64fbf1084590997741fad..af5adaba60c4d31c3dd4b7531d5a7cccfb2c7541 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -385,8 +385,12 @@ void InspectorOverlay::rebuildOverlayPage()
IntRect visibleRectInDocument = view->getScrollableArea()->visibleContentRect();
IntSize viewportSize = m_webViewImpl->page()->frameHost().visualViewport().size();
- toLocalFrame(overlayPage()->mainFrame())->view()->resize(viewportSize);
+ LocalFrame* frame = toLocalFrame(overlayPage()->mainFrame());
+ frame->view()->resize(viewportSize);
overlayPage()->frameHost().visualViewport().setSize(viewportSize);
+ float windowToViewportScale = m_webViewImpl->chromeClient().windowToViewportScalar(1.0f);
+ frame->setPageZoomFactor(windowToViewportScale);
+
reset(viewportSize, visibleRectInDocument.location());
drawNodeHighlight();
@@ -532,8 +536,16 @@ void InspectorOverlay::reset(const IntSize& viewportSize, const IntPoint& docume
std::unique_ptr<protocol::DictionaryValue> resetData = protocol::DictionaryValue::create();
resetData->setNumber("deviceScaleFactor", m_webViewImpl->page()->deviceScaleFactor());
resetData->setNumber("pageScaleFactor", m_webViewImpl->page()->pageScaleFactor());
- resetData->setObject("viewportSize", buildObjectForSize(viewportSize));
- resetData->setNumber("pageZoomFactor", m_webViewImpl->mainFrameImpl()->frame()->pageZoomFactor());
+
+ IntRect viewportInScreen = m_webViewImpl->chromeClient().viewportToScreen(
+ IntRect(IntPoint(), viewportSize), m_webViewImpl->mainFrameImpl()->frame()->view());
+ resetData->setObject("viewportSize", buildObjectForSize(viewportInScreen.size()));
+
+ // The zoom factor in the overlay frame already has been multiplied by the window to viewport scale
+ // (aka device scale factor), so cancel it.
+ float windowToViewportScale = m_webViewImpl->chromeClient().windowToViewportScalar(1.0f);
+ resetData->setNumber("pageZoomFactor", m_webViewImpl->mainFrameImpl()->frame()->pageZoomFactor() / windowToViewportScale);
+
resetData->setNumber("scrollX", documentScrollOffset.x());
resetData->setNumber("scrollY", documentScrollOffset.y());
evaluateInOverlay("reset", std::move(resetData));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698