Replace the old URL format for PVer4 requests with the new format.

Replace the old URL format for PVer4 requests with the new format.
The new URL format is described in the bug.
The old format doesn't seem to be working currently so this is a good time to
switch. See: http://b/29229908

BUG=603348, 543161
Committed: https://crrev.com/377c783165d3e992e5475c797e77d654c824b49b
Cr-Commit-Position: refs/heads/master@{#399087}

[vakh (use Gerrit instead), 2016-06-09 08:02:46]

Move #include to *.cc and use forward declaration in .h

[vakh (use Gerrit instead), 2016-06-09 08:04:41]

vakh@chromium.org changed reviewers:
+ awoz@google.com, nparker@chromium.org

[vakh (use Gerrit instead), 2016-06-09 08:04:41]

nparker: Please review changes in *

awoz: Please review the URL changes in v4_protocol_manager_util*

[Nathan Parker, 2016-06-09 20:22:18]

lgtm

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
File components/safe_browsing_db/v4_get_hash_protocol_manager.cc (right):

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
components/safe_browsing_db/v4_get_hash_protocol_manager.cc:408: GURL
V4GetHashProtocolManager::GetHashUrlAndUpdateHeaders(
nit: What is the "update" mean here?  How about GetHashUrlAndHeaders? Same in
v4protocolmanagerutil.

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
File components/safe_browsing_db/v4_protocol_manager_util.cc (right):

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
components/safe_browsing_db/v4_protocol_manager_util.cc:109:
headers->SetHeaderIfMissing("X-HTTP-Method-Override", "POST");
If we get an explanation for this, we should add it in the comments here.

[woz, 2016-06-09 20:45:46]

awoz@chromium.org changed reviewers:
+ awoz@chromium.org

[woz, 2016-06-09 20:45:47]

lgtm

[vakh (use Gerrit instead), 2016-06-09 21:00:18]

CR feedback: nparker. GetRequestUrlAndUpdateHeaders -> GetRequestUrlAndHeaders

[vakh (use Gerrit instead), 2016-06-09 21:01:38]

The CQ bit was checked by vakh@chromium.org

[vakh (use Gerrit instead), 2016-06-09 21:01:39]

The patchset sent to the CQ was uploaded after l-g-t-m from awoz@chromium.org,
nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2057433002/#ps40001
(title: "CR feedback: nparker. GetRequestUrlAndUpdateHeaders ->
GetRequestUrlAndHeaders")

[vakh (use Gerrit instead), 2016-06-09 21:02:16]

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
File components/safe_browsing_db/v4_get_hash_protocol_manager.cc (right):

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
components/safe_browsing_db/v4_get_hash_protocol_manager.cc:408: GURL
V4GetHashProtocolManager::GetHashUrlAndUpdateHeaders(
On 2016/06/09 20:22:18, Nathan Parker wrote:
> nit: What is the "update" mean here?  How about GetHashUrlAndHeaders? Same in
> v4protocolmanagerutil.

Done.

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
File components/safe_browsing_db/v4_protocol_manager_util.cc (right):

https://codereview.chromium.org/2057433002/diff/20001/components/safe_browsin...
components/safe_browsing_db/v4_protocol_manager_util.cc:109:
headers->SetHeaderIfMissing("X-HTTP-Method-Override", "POST");
On 2016/06/09 20:22:18, Nathan Parker wrote:
> If we get an explanation for this, we should add it in the comments here.

Done.

[commit-bot: I haz the power, 2016-06-09 21:02:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057433002/40001

[commit-bot: I haz the power, 2016-06-10 01:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 01:08:22]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vakh (use Gerrit instead), 2016-06-10 01:11:21]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2016-06-10 01:11:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057433002/40001

[commit-bot: I haz the power, 2016-06-10 04:28:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 04:31:22]

Description was changed from

==========
Replace the old URL format for PVer4 requests with the new format.
The new URL format is described in the bug.
The old format doesn't seem to be working currently so this is a good time to
switch. See: http://b/29229908

BUG=603348, 543161
==========

to

==========
Replace the old URL format for PVer4 requests with the new format.
The new URL format is described in the bug.
The old format doesn't seem to be working currently so this is a good time to
switch. See: http://b/29229908

BUG=603348, 543161

Committed: https://crrev.com/377c783165d3e992e5475c797e77d654c824b49b
Cr-Commit-Position: refs/heads/master@{#399087}
==========

[commit-bot: I haz the power, 2016-06-10 04:31:23]

Patchset 3 (id:??) landed as
https://crrev.com/377c783165d3e992e5475c797e77d654c824b49b
Cr-Commit-Position: refs/heads/master@{#399087}