Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1655)

Unified Diff: components/safe_browsing_db/v4_update_protocol_manager.h

Issue 2057433002: Replace the old URL format for PVer4 requests with the new format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback: nparker. GetRequestUrlAndUpdateHeaders -> GetRequestUrlAndHeaders Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_update_protocol_manager.h
diff --git a/components/safe_browsing_db/v4_update_protocol_manager.h b/components/safe_browsing_db/v4_update_protocol_manager.h
index 92be60676f5990f9f83d7b5dfbaf7b5065d5425d..4b2031779d1e3f2b3cd1f72158d5ef8adda66f2e 100644
--- a/components/safe_browsing_db/v4_update_protocol_manager.h
+++ b/components/safe_browsing_db/v4_update_protocol_manager.h
@@ -25,7 +25,8 @@
#include "components/safe_browsing_db/util.h"
#include "components/safe_browsing_db/v4_protocol_manager_util.h"
#include "net/url_request/url_fetcher_delegate.h"
-#include "url/gurl.h"
+
+class GURL;
namespace net {
class URLFetcher;
@@ -94,10 +95,13 @@ class V4UpdateProtocolManager : public net::URLFetcherDelegate,
TestGetUpdatesWithOneBackoff);
friend class V4UpdateProtocolManagerFactoryImpl;
- // The method to generate the URL for the request to be sent to the server.
+ // The method to populate |gurl| with the URL to be sent to the server.
// |request_base64| is the base64 encoded form of an instance of the protobuf
- // FetchThreatListUpdatesRequest.
- GURL GetUpdateUrl(const std::string& request_base64) const;
+ // FetchThreatListUpdatesRequest. Also sets the appropriate header values for
+ // sending PVer4 requests in |headers|.
+ void GetUpdateUrlAndHeaders(const std::string& request_base64,
+ GURL* gurl,
+ net::HttpRequestHeaders* headers) const;
// Fills a FetchThreatListUpdatesRequest protocol buffer for a request.
// Returns the serialized and base 64 encoded request as a string.

Powered by Google App Engine
This is Rietveld 408576698