Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/common/chrome_utility_messages.h

Issue 20572004: Add media file validation to utility process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_utility_messages.h
diff --git a/chrome/common/chrome_utility_messages.h b/chrome/common/chrome_utility_messages.h
index 3534f60e17e8a0635e08dfd07b7eb79763058e45..2033c1c9e6e4475f28bccf72b22c46193a1f81c2 100644
--- a/chrome/common/chrome_utility_messages.h
+++ b/chrome/common/chrome_utility_messages.h
@@ -189,6 +189,14 @@ IPC_MESSAGE_CONTROL2(ChromeUtilityMsg_IndexPicasaAlbumsContents,
std::vector<picasa::FolderINIContents> /* folders_inis */)
#endif // defined(OS_WIN) || defined(OS_MACOSX)
+// Tell the utility process to attempt to validate the passed media file. The
+// file will undergo basic sanity checks and will be decoded for up to
+// |milliseconds_of_decoding|. It is still not safe to decode the file in the
Lei Zhang 2013/08/07 20:56:21 Is the time wall clock time, or time in the media
vandebo (ex-Chrome) 2013/08/07 21:00:43 "wall clock time" added
+// browser process after this check.
+IPC_MESSAGE_CONTROL2(ChromeUtilityMsg_CheckMediaFile,
Lei Zhang 2013/08/07 20:56:21 Put this in the OS_WIN / OS_MACOSX section above?
vandebo (ex-Chrome) 2013/08/07 21:00:43 Also applies to Linux.
Lei Zhang 2013/08/07 22:30:14 Oh right. Should this be !(Android || iOS) then, s
vandebo (ex-Chrome) 2013/08/07 23:26:12 Done.
+ int64 /* milliseconds_of_decoding */,
+ IPC::PlatformFileForTransit /* Media file to parse */)
+
//------------------------------------------------------------------------------
// Utility process host messages:
// These are messages from the utility process to the browser.
@@ -312,3 +320,8 @@ IPC_MESSAGE_CONTROL3(ChromeUtilityHostMsg_ParsePicasaPMPDatabase_Finished,
IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_IndexPicasaAlbumsContents_Finished,
picasa::AlbumImagesMap /* albums_images */)
#endif // defined(OS_WIN) || defined(OS_MACOSX)
+
+// Reply after checking the passed media file. A true result indicates that
+// the file appears to be a well formed media file.
+IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_CheckMediaFile_Finished,
+ bool /* passed_checks */)

Powered by Google App Engine
This is Rietveld 408576698