Add media file validation to utility process

chrome/common/chrome_utility_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, so no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 171 matching lines @@
 IPC_MESSAGE_CONTROL1(ChromeUtilityMsg_ParsePicasaPMPDatabase,
                      picasa::AlbumTableFilesForTransit /* album_table_files */)
 
 // Tells the utility process to index the Picasa user-created Album contents
 // by parsing all the INI files in Picasa Folders.
 IPC_MESSAGE_CONTROL2(ChromeUtilityMsg_IndexPicasaAlbumsContents,
                      picasa::AlbumUIDSet /* album_uids */,
                      std::vector<picasa::FolderINIContents> /* folders_inis */)
 #endif  // defined(OS_WIN) || defined(OS_MACOSX)
 
+// Tell the utility process to attempt to validate the passed media file. The
+// file will undergo basic sanity checks and will be decoded for up to
+// |milliseconds_of_decoding|. It is still not safe to decode the file in the

[Lei Zhang, 2013/08/07 20:56:21]

Is the time wall clock time, or time in the media file?

[vandebo (ex-Chrome), 2013/08/07 21:00:43]

"wall clock time" added

+// browser process after this check.
+IPC_MESSAGE_CONTROL2(ChromeUtilityMsg_CheckMediaFile,

[Lei Zhang, 2013/08/07 20:56:21]

Put this in the OS_WIN / OS_MACOSX section above? Ditto elsewhere.

[vandebo (ex-Chrome), 2013/08/07 21:00:43]

Also applies to Linux.

[Lei Zhang, 2013/08/07 22:30:14]

Oh right. Should this be !(Android || iOS) then, since there's no media
galleries on those platforms?

[vandebo (ex-Chrome), 2013/08/07 23:26:12]

Done.

+                     int64 /* milliseconds_of_decoding */,
+                     IPC::PlatformFileForTransit /* Media file to parse */)
+
 //------------------------------------------------------------------------------
 // Utility process host messages:
 // These are messages from the utility process to the browser.
 
 // Reply when the utility process is done unpacking an extension.  |manifest|
 // is the parsed manifest.json file.
 // The unpacker should also have written out files containing the decoded
 // images and message catalogs from the extension. The data is written into a
 // DecodedImages struct into a file named kDecodedImagesFilename in the
 // directory that was passed in. This is done because the data is too large to
@@ skipping 103 matching lines @@
 IPC_MESSAGE_CONTROL3(ChromeUtilityHostMsg_ParsePicasaPMPDatabase_Finished,
                      bool /* parse_success */,
                      std::vector<picasa::AlbumInfo> /* albums */,
                      std::vector<picasa::AlbumInfo> /* folders */)
 
 // Reply after indexing the Picasa user-created Album contents by parsing all
 // the INI files in Picasa Folders.
 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_IndexPicasaAlbumsContents_Finished,
                      picasa::AlbumImagesMap /* albums_images */)
 #endif  // defined(OS_WIN) || defined(OS_MACOSX)
+
+// Reply after checking the passed media file. A true result indicates that
+// the file appears to be a well formed media file.
+IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_CheckMediaFile_Finished,
+                     bool /* passed_checks */)