Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 20572004: Add media file validation to utility process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/common/chrome_utility_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_main_delegate.cc
diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc
index d3153f67d515841fa72025472b4cc8aa6388e7cc..66c8a8708ec4ddfe98cee2750a1264a6f6206513 100644
--- a/chrome/app/chrome_main_delegate.cc
+++ b/chrome/app/chrome_main_delegate.cc
@@ -5,6 +5,7 @@
#include "chrome/app/chrome_main_delegate.h"
#include "base/command_line.h"
+#include "base/files/file_path.h"
#include "base/lazy_instance.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/stats_counters.h"
@@ -639,8 +640,11 @@ void ChromeMainDelegate::PreSandboxStartup() {
#endif // defined(OS_MACOSX)
#if !defined(CHROME_MULTIPLE_DLL_BROWSER)
- if (process_type == switches::kUtilityProcess)
- chrome::ChromeContentUtilityClient::PreSandboxStartup();
+ if (process_type == switches::kUtilityProcess) {
+ base::FilePath media_path;
+ PathService::Get(content::DIR_MEDIA_LIBS, &media_path);
Lei Zhang 2013/08/07 20:56:21 Why not just do this in PreSandboxStartup() ?
vandebo (ex-Chrome) 2013/08/07 21:00:43 Layering violation - utility doesn't depend on con
Lei Zhang 2013/08/07 22:30:14 chrome/DEPS says anyone can use content/public/com
vandebo (ex-Chrome) 2013/08/07 23:26:12 Hmm, indeed. Fixed.
+ chrome::ChromeContentUtilityClient::PreSandboxStartup(media_path);
+ }
#endif
}
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/common/chrome_utility_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698