Add media file validation to utility process

chrome/app/chrome_main_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_main_delegate.h"
 
 #include "base/command_line.h"
+#include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/stats_counters.h"
 #include "base/path_service.h"
 #include "base/process/memory.h"
 #include "base/process/process_handle.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_content_browser_client.h"
@@ skipping 614 matching lines @@
     CHECK(!loaded_locale.empty()) << "Locale could not be found for " <<
         locale;
 
 #if defined(OS_MACOSX)
     // Update the process name (need resources to get the strings, so
     // only do this when ResourcesBundle has been initialized).
     SetMacProcessName(command_line);
 #endif  // defined(OS_MACOSX)
 
 #if !defined(CHROME_MULTIPLE_DLL_BROWSER)
-    if (process_type == switches::kUtilityProcess)
-      chrome::ChromeContentUtilityClient::PreSandboxStartup();
+    if (process_type == switches::kUtilityProcess) {
+      base::FilePath media_path;
+      PathService::Get(content::DIR_MEDIA_LIBS, &media_path);

[Lei Zhang, 2013/08/07 20:56:21]

Why not just do this in PreSandboxStartup() ?

[vandebo (ex-Chrome), 2013/08/07 21:00:43]

Layering violation - utility doesn't depend on content

[Lei Zhang, 2013/08/07 22:30:14]

chrome/DEPS says anyone can use content/public/common.

[vandebo (ex-Chrome), 2013/08/07 23:26:12]

Hmm, indeed.  Fixed.

+      chrome::ChromeContentUtilityClient::PreSandboxStartup(media_path);
+    }
 #endif
   }
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
   // Needs to be called after we have chrome::DIR_USER_DATA.  BrowserMain
   // sets this up for the browser process in a different manner. Zygotes
   // need to call InitCrashReporter() in RunZygote().
   if (!process_type.empty() && process_type != switches::kZygoteProcess) {
 #if defined(OS_ANDROID)
     InitNonBrowserCrashReporterForAndroid();
@@ skipping 135 matching lines @@
 }
 
 content::ContentUtilityClient*
 ChromeMainDelegate::CreateContentUtilityClient() {
 #if defined(CHROME_MULTIPLE_DLL_BROWSER)
   return NULL;
 #else
   return &g_chrome_content_utility_client.Get();
 #endif
 }