third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2057113002: [css-grid] Allow percentage values for column and row gutters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2057113002: [css-grid] Allow percentage values for column and row gutters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Grid gaps don't support unitless quirk. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index f0fb3cf80a337606b58d189a656e63a7acaf3002..e918920c51c6868ee91360d3ec11bff37e516e17 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -842,7 +842,7 @@ static CSSValue* valueForGridTrackList(GridTrackSizingDirection direction, const

ASSERT(trackPositions.size() - 1 >= trackSizes.size());

size_t i;

- LayoutUnit gutterSize = grid->guttersSize(direction, 2);

+ LayoutUnit gutterSize = grid->guttersSize(direction, 2, isRowAxis ? grid->contentLogicalWidth() : grid->contentLogicalHeight());

LayoutUnit offsetBetweenTracks = grid->offsetBetweenTracks(direction);

for (i = 0; i < trackPositions.size() - 2; ++i) {

addValuesForNamedGridLinesAtIndex(collector, i, *list);