third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt - Issue 2057113002: [css-grid] Allow percentage values for column and row gutters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt

Issue 2057113002: [css-grid] Allow percentage values for column and row gutters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Grid gaps don't support unitless quirk. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt

index 473ba8fbd544dc01f8dc5c283989497fcf716ba0..be8ce2cc9cfbc85050303a31a26204976b790430 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set-expected.txt

@@ -20,6 +20,8 @@ PASS window.getComputedStyle(gridRowColumnGaps, '').getPropertyValue('grid-row-g

PASS window.getComputedStyle(gridRowColumnGaps, '').getPropertyValue('grid-column-gap') is "16px"

PASS window.getComputedStyle(gridRowColumnGaps, '').getPropertyValue('grid-row-gap') is "12px"

PASS window.getComputedStyle(gridRowColumnGaps, '').getPropertyValue('grid-column-gap') is "16px"

+PASS window.getComputedStyle(gridRowColumnPercentGaps, '').getPropertyValue('grid-row-gap') is "10%"

+PASS window.getComputedStyle(gridRowColumnPercentGaps, '').getPropertyValue('grid-column-gap') is "15%"

PASS window.getComputedStyle(gridRowColumnInheritGaps, '').getPropertyValue('grid-row-gap') is "25px"

PASS window.getComputedStyle(gridRowColumnInheritGaps, '').getPropertyValue('grid-column-gap') is "25px"

PASS window.getComputedStyle(gridRowColumnInitialGaps, '').getPropertyValue('grid-row-gap') is "0px"