Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html

Issue 2057113002: [css-grid] Allow percentage values for column and row gutters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Grid gaps don't support unitless quirk. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html
index 7af88faab4538864b835896ba7ccf141c946a17e..7aeae091e252e2a5161ffd4c195660bfa7387784 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html
@@ -11,6 +11,10 @@
grid-row-gap: 12px;
grid-column-gap: 1rem;
}
+.gridRowColumnPercentGaps {
+ grid-row-gap: 10%;
+ grid-column-gap: 15%;
+}
.gridRowColumnInheritGaps {
grid-row-gap: inherit;
grid-column-gap: inherit;
@@ -23,7 +27,7 @@
grid-row-gap: calc(10px + 3px);
grid-column-gap: calc(2px + 1vw);
}
-.gridInvalidRowGap { grid-row-gap: 10%; }
+.gridInvalidRowGap { grid-row-gap: -10px; }
.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; }
.gridInvalidMultipleRowColumnGaps {
grid-row-gap: 10px 1px;
@@ -49,6 +53,7 @@
<div class="grid gridRowGap" id="gridRowGap"></div>
<div class="grid gridCalcGaps" id="gridCalcGaps"></div>
<div class="grid gridRowColumnGaps" id="gridRowColumnGaps"></div>
+<div class="grid gridRowColumnPercentGaps" id="gridRowColumnPercentGaps"></div>
<div class="grid gridSimpleGap">
<div class="grid gridRowColumnInheritGaps" id="gridRowColumnInheritGaps"></div>
</div>
@@ -78,6 +83,7 @@ testGridGapDefinitionsValues("gridRowGap", "32px", "0px");
testGridGapDefinitionsValues("gridCalcGaps", "13px", "10px");
testGridGapDefinitionsValues("gridRowColumnGaps", "12px", "16px");
testGridGapDefinitionsValues("gridRowColumnGaps", "12px", "16px");
+testGridGapDefinitionsValues("gridRowColumnPercentGaps", "10%", "15%");
testGridGapDefinitionsValues("gridRowColumnInheritGaps", "25px", "25px");
testGridGapDefinitionsValues("gridRowColumnInitialGaps", "0px", "0px");

Powered by Google App Engine
This is Rietveld 408576698