Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2057053002: V8: Remove infra-side gn defaults (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Remove infra-side gn defaults For both sysroot and icu data file, v8 uses now the chromium default. Also the test isolation mode will be controlled through MB like all other flags. BUG=474921 TBR=jochen@chromium.org, vogelheim@chromium.org, kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/0e7d764eb340ba07e08362321e7dbab7aec32796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -98 lines) Patch
M scripts/slave/recipe_modules/v8/chromium_config.py View 1 chunk +0 lines, -6 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_dynamorio_linux_v8_dr.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_arm64___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_no_inline___release_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gcov_coverage.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_arm___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_mipsel___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___arm64___sim___MSAN.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___full_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___interpreted_regexp.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___noi18n___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___presubmit.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___swarming_staging.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___vtunejit.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_gcc_4_8.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___nosnap___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc64___sim.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc___sim.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_greedy_allocator_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_gc_stress_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_avx2_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_compile_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_greedy_allocator_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_greedy_allocator_dbg_positional_extra_flags.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mips64el_compile_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mipsel_compile_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Achenbach
PTAL - this only affects the gn fyi step used in the comparison steps. Is ...
4 years, 6 months ago (2016-06-10 08:43:34 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-10 08:44:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057053002/1
4 years, 6 months ago (2016-06-10 08:46:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/0e7d764eb340ba07e08362321e7dbab7aec32796
4 years, 6 months ago (2016-06-10 08:49:37 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 08:49:38 UTC) #11
kjellander_chromium
4 years, 6 months ago (2016-06-10 09:47:43 UTC) #12
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698