scripts/slave/recipe_modules/v8/chromium_config.py - Issue 2057053002: V8: Remove infra-side gn defaults

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/chromium_config.py

Issue 2057053002: V8: Remove infra-side gn defaults (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/v8/chromium_config.py

diff --git a/scripts/slave/recipe_modules/v8/chromium_config.py b/scripts/slave/recipe_modules/v8/chromium_config.py

index 56dc4446085b92d487673673d677a429866bca8d..377cb84983c176af6d4e98a65233ee9aa5a3f10f 100644

--- a/scripts/slave/recipe_modules/v8/chromium_config.py

+++ b/scripts/slave/recipe_modules/v8/chromium_config.py

@@ -38,12 +38,6 @@ def v8(c):

c.build_config_fs = c.BUILD_CONFIG

c.compile_py.pass_arch_flag = True

- # TODO(machenbach): Remove this as soon as a project specific default is

- # possible. Also add corresponding gn_args for all gyp_defines in this

- # file.

- c.gn_args.append('use_sysroot=false')

- c.gn_args.append('icu_use_data_file = false')

- c.gn_args.append('v8_test_isolation_mode = "prepare"')

@CONFIG_CTX(includes=['v8'])

def arm_hard_float(c):

« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json » ('j') | no next file with comments »