Rename remaining types so that all begin Payment*

Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to PaymentShippingOption.

BUG=618754
RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5

Committed: https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33
Cr-Commit-Position: refs/heads/master@{#400475}

[Byoungkwon Ko, 2016-06-09 18:12:09]

Description was changed from

==========
[WIP] Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754
==========

to

==========
[WIP] Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5
==========

[Byoungkwon Ko, 2016-06-09 18:12:10]

gogag2@gmail.com changed reviewers:
+ jinho.bang@samsung.com, rouslan@chromium.org

[Byoungkwon Ko, 2016-06-09 18:14:37]

Dear zino and Rouslan

Hi.
I am adding Payment* to CurrencyAmount and ShippingOption.
But  I'm not sure if it's a right way.
Could you check it out?
Thanks.

[zino, 2016-06-09 18:18:41]

On 2016/06/09 18:14:37, Byoungkwon Ko wrote:
> Dear zino and Rouslan
> 
> Hi.
> I am adding Payment* to CurrencyAmount and ShippingOption.
> But  I'm not sure if it's a right way.
> Could you check it out?
> Thanks.

I think you should avoid to use "[ImplementedAs]" if possible.
According to the bindings guide[1], it says "[ImplementedAs] extended attribute;
this is strongly discouraged"
So, let's rename all of things. (c++, idl and so on)

[please use gerrit instead, 2016-06-09 20:43:52]

https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/CurrencyAmount.idl (right):

https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/CurrencyAmount.idl:9:
ImplementedAs=CurrencyAmount
I prefer to not have ImplementedAs=, unless absolutely necessary. I recommend
that you go through all of the code in Chrome that mentions CurrencyAmount and
rename it to PaymentCurrencyAmount. This will make maintenance more
straightforward for us.

https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/ShippingOption.idl (right):

https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/ShippingOption.idl:9:
ImplementedAs=ShippingOption
ditto

[Byoungkwon Ko, 2016-06-12 15:19:25]

gogag2@gmail.com changed reviewers:
+ mariakhomenko@chromium.org, palmer@chromium.org

[Byoungkwon Ko, 2016-06-12 15:25:12]

Description was changed from

==========
[WIP] Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5
==========

to

==========
Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5
==========

[Byoungkwon Ko, 2016-06-13 14:53:52]

On 2016/06/09 20:43:52, Rouslan (ツ) wrote:
>
https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/payments/CurrencyAmount.idl (right):
> 
>
https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/payments/CurrencyAmount.idl:9:
> ImplementedAs=CurrencyAmount
> I prefer to not have ImplementedAs=, unless absolutely necessary. I recommend
> that you go through all of the code in Chrome that mentions CurrencyAmount and
> rename it to PaymentCurrencyAmount. This will make maintenance more
> straightforward for us.
> 
>
https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/payments/ShippingOption.idl (right):
> 
>
https://codereview.chromium.org/2056803002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/payments/ShippingOption.idl:9:
> ImplementedAs=ShippingOption
> ditto

Dear Rouslan.

I uploaded new patch!
Plz take a look : )
Thanks.

[please use gerrit instead, 2016-06-13 15:03:05]

A few minor comments and then you're good to go. Well done!

https://codereview.chromium.org/2056803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl
(right):

https://codereview.chromium.org/2056803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl:5: //
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#currencya...
https://w3c.github.io/browser-payment-api/#paymentcurrencyamount

https://codereview.chromium.org/2056803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.idl (right):

https://codereview.chromium.org/2056803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.idl:20: readonly
attribute DOMString? paymentShippingOption;
This one did not change: "shippingOption"

https://codereview.chromium.org/2056803002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentShippingOption.idl
(right):

https://codereview.chromium.org/2056803002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentShippingOption.idl:5: //
https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#shippingo...
https://w3c.github.io/browser-payment-api/#paymentshippingoption-dictionary

[Maria, 2016-06-13 16:21:01]

lgtm for
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
only

[palmer, 2016-06-13 19:12:20]

LGTM % Rouslan's notes.

[Byoungkwon Ko, 2016-06-16 04:41:15]

The CQ bit was checked by gogag2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 04:41:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056803002/40001

[commit-bot: I haz the power, 2016-06-16 04:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 04:43:31]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Byoungkwon Ko, 2016-06-17 16:11:50]

Dear Rouslan.

I updated for PaymentRequestTest.cpp.
Could you review for it?
Thanks. : )

[please use gerrit instead, 2016-06-17 16:12:38]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 16:12:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056803002/80001

[please use gerrit instead, 2016-06-17 16:31:51]

lgtm

[please use gerrit instead, 2016-06-17 16:31:58]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2016-06-17 16:32:05]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-06-17 16:32:05]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2056803002/#ps80001
(title: "Rename remaining types so that all begin Payment*")

[commit-bot: I haz the power, 2016-06-17 16:32:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056803002/80001

[commit-bot: I haz the power, 2016-06-17 19:37:16]

Description was changed from

==========
Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5
==========

to

==========
Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5
==========

[commit-bot: I haz the power, 2016-06-17 19:37:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-17 19:39:15]

Description was changed from

==========
Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5
==========

to

==========
Rename remaining types so that all begin Payment*

Modified CurrencyAmount to PaymentCurrencyAmount and ShippingOption to
PaymentShippingOption.

BUG=618754

RelatedLink=https://github.com/w3c/browser-payment-api/commit/26b092664b26cf06293a3eab462ef8c4005c82f5

Committed: https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33
Cr-Commit-Position: refs/heads/master@{#400475}
==========

[commit-bot: I haz the power, 2016-06-17 19:39:16]

Patchset 5 (id:??) landed as
https://crrev.com/ef35132022c6123992c4e5666213b5e481b39d33
Cr-Commit-Position: refs/heads/master@{#400475}

[Byoungkwon Ko, 2016-12-16 18:05:13]

Patchset #6 (id:100001) has been deleted

[Byoungkwon Ko, 2016-12-16 18:09:04]

Patchset #6 (id:120001) has been deleted