third_party/WebKit/Source/modules/payments/CurrencyAmount.idl - Issue 2056803002: Rename remaining types so that all begin Payment*

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/CurrencyAmount.idl

Issue 2056803002: Rename remaining types so that all begin Payment* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#currencya mount	5 // https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#currencya mount

6	6

7 [	7 [

8 RuntimeEnabled=PaymentRequest	8 RuntimeEnabled=PaymentRequest,

9 ] dictionary CurrencyAmount {	9 ImplementedAs=CurrencyAmount
	please use gerrit instead 2016/06/09 20:43:51 I prefer to not have ImplementedAs=, unless absolu I prefer to not have ImplementedAs=, unless absolutely necessary. I recommend that you go through all of the code in Chrome that mentions CurrencyAmount and rename it to PaymentCurrencyAmount. This will make maintenance more straightforward for us.
	10 ] dictionary PaymentCurrencyAmount {

10 required DOMString currency;	11 required DOMString currency;

11 required DOMString value;	12 required DOMString value;

12 };	13 };

OLD	NEW