Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2056733003: Change CFXJSE_Context::GetGlobalObject to return (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@to_string_return
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change CFXJSE_Context::GetGlobalObject to return This Cl changes CFXJSE_Context::GetGlobalObject to return a std::unique_ptr<CFXJSE_Value> instead of accepting a CFXJSE_Value out parameter. All usages created the CFXJSE_Value with the same runtime as the caller. Committed: https://pdfium.googlesource.com/pdfium/+/3cace320e07bb954710c50fc7634ca3a8f3eda38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M xfa/fxfa/parser/xfa_script_imp.cpp View 3 chunks +4 lines, -13 lines 0 comments Download
M xfa/fxjse/context.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/context.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-09 17:47:21 UTC) #2
Tom Sepez
lgtm nice.
4 years, 6 months ago (2016-06-09 18:00:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056733003/1
4 years, 6 months ago (2016-06-09 18:49:10 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 18:49:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3cace320e07bb954710c50fc7634ca3a8f3e...

Powered by Google App Engine
This is Rietveld 408576698