xfa/fxjse/context.h - Issue 2056733003: Change CFXJSE_Context::GetGlobalObject to return

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxjse/context.h

Issue 2056733003: Change CFXJSE_Context::GetGlobalObject to return (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@to_string_return

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxjse/context.h

diff --git a/xfa/fxjse/context.h b/xfa/fxjse/context.h

index 4219713ece2d2bc8b6b20f787d9f3521f83ded41..0bb1e4fa2666e8f27a1ca07d95c97d881170c453 100644

--- a/xfa/fxjse/context.h

+++ b/xfa/fxjse/context.h

@@ -27,7 +27,7 @@ class CFXJSE_Context {

~CFXJSE_Context();

V8_INLINE v8::Isolate* GetRuntime(void) { return m_pIsolate; }

- void GetGlobalObject(CFXJSE_Value* pValue);

+ std::unique_ptr<CFXJSE_Value> GetGlobalObject();

void EnableCompatibleMode();

FX_BOOL ExecuteScript(const FX_CHAR* szScript,

CFXJSE_Value* lpRetValue,

« no previous file with comments | « xfa/fxfa/parser/xfa_script_imp.cpp ('k') | xfa/fxjse/context.cpp » ('j') | no next file with comments »