Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2056683003: mash: Move tray_constants.h and FixedSizedImageView to //ash/common (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, derat+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move tray_constants.h and FixedSizedImageView to //ash/common These are dependencies of TrayUpdate, which I am moving to //ash/common TBR because this is a purely mechanical move: * move_source_file.py ash/system/tray/tray_constants.h ash/common/system/tray/ * move_source_file.py ash/system/tray/tray_constants.cc ash/common/system/tray/ * move_source_file.py ash/system/tray/fixed_sized_image_view.h ash/common/system/tray/ * move_source_file.py ash/system/tray/fixed_sized_image_view.cc ash/common/system/tray/ BUG=615155 TEST=compiles TBR=msw@chromium.org Committed: https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f Cr-Commit-Position: refs/heads/master@{#399030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -309 lines) Patch
M ash/ash.gyp View 3 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/tray/fixed_sized_image_view.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/fixed_sized_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/tray_constants.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/tray/tray_constants.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/audio/tray_audio.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/audio/volume_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/cast/tray_cast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/label_tray_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_sms.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/vpn_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_status_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/session/logout_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/tray_tracing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_default_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/fixed_sized_image_view.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ash/system/tray/fixed_sized_image_view.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M ash/system/tray/hover_highlight_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/special_popup_row.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/throbber_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/tray_bar_button_with_title.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/tray_constants.h View 1 chunk +0 lines, -89 lines 0 comments Download
D ash/system/tray/tray_constants.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M ash/system/tray/tray_details_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_item_more.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_header_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_item_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_update.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/user/button_from_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 2 chunks +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056683003/1
4 years, 6 months ago (2016-06-09 21:09:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 22:05:09 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 22:05:22 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 22:07:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12aaeb94fc430796833936016bbc1f29c23ee38f
Cr-Commit-Position: refs/heads/master@{#399030}

Powered by Google App Engine
This is Rietveld 408576698