Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2055053002: mash: Convert ash::ShellDelegate from aura::Window to WmWindow (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@movetrayupdate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Convert ash::ShellDelegate from aura::Window to WmWindow Also remove unnecessary shell.h include from shell_delegate.h and clean up includes elsewhere. BUG=615155 TEST=existing ash_unittests and chrome unit_tests Committed: https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18 Cr-Commit-Position: refs/heads/master@{#399097}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M ash/aura/wm_shell_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/common/wm_shell.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/shell_delegate.h View 5 chunks +3 lines, -6 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/session_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
James Cook
sky, please take a look. Now that I look at it more I think I ...
4 years, 6 months ago (2016-06-09 22:52:32 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-09 23:07:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055053002/20001
4 years, 6 months ago (2016-06-09 23:41:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on ...
4 years, 6 months ago (2016-06-10 00:51:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055053002/20001
4 years, 6 months ago (2016-06-10 04:17:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 04:38:31 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 04:41:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd4ba1d215ee2450d23ac71a1d3728d4bb21de18
Cr-Commit-Position: refs/heads/master@{#399097}

Powered by Google App Engine
This is Rietveld 408576698