[wasm] Separate compilation from instantiation

src/wasm/wasm-module.h

Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 615f633a95dd8549909a5e70964276473ecfc93d..8da421eb6dd9b3d6894827bcc3a77e434922e187 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -210,6 +210,8 @@ struct WasmModule {
   // Creates a new instantiation of the module in the given isolate.
   MaybeHandle<JSObject> Instantiate(Isolate* isolate, Handle<JSReceiver> ffi,
                                     Handle<JSArrayBuffer> memory) const;
+
+  Handle<FixedArray> Compile(Isolate* isolate) const;
 };
 
 // An instantiated WASM module, including memory, function table, etc.
@@ -225,13 +227,14 @@ struct WasmModuleInstance {
   std::vector<Handle<Code>> import_code;    // code objects for each import.
   // -- raw memory ------------------------------------------------------------
   byte* mem_start;  // start of linear memory.
-  size_t mem_size;  // size of the linear memory.
+  uint32_t mem_size;  // size of the linear memory.

[titzer, 2016/06/16 23:12:14]

I think this needs to be bigger, probably uint64_t, because 4GB won't fit here.

[Mircea Trofin, 2016/06/16 23:43:11]

Oh, you mean the specific case when we allocate 4GB. Hmm... You are correct that
we need 32+1 bytes for that size. I'll change it to uint64 then.

I now understand why size_t before. I'd prefer uint64_t rather, and checking the
size,
to keep things consistent accross architectures.

   // -- raw globals -----------------------------------------------------------
   byte* globals_start;  // start of the globals area.
 
   explicit WasmModuleInstance(const WasmModule* m)
       : module(m),
         function_code(m->functions.size()),
+        import_code(m->import_table.size()),
         mem_start(nullptr),
         mem_size(0),
         globals_start(nullptr) {}