Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issue 2056593005: Move more helper methods out of CSSPropertyParser (Closed)

Created:
4 years, 6 months ago by rwlbuis
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more helper methods out of CSSPropertyParser Move more helper methods out of CSSPropertyParser, isSystemColor and isValidNumericValue make more sense in StyleColor and CSSParserToken respectively. Also remove a superfluous std::isfinite check. Committed: https://crrev.com/7c190d0749ed473cdd9dea6c29181336306c9308 Cr-Commit-Position: refs/heads/master@{#399215}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M third_party/WebKit/Source/core/css/StyleColor.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleColor.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 3 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
rwlbuis
PTAL.
4 years, 6 months ago (2016-06-09 23:40:50 UTC) #5
Timothy Loh
On 2016/06/09 23:40:50, rwlbuis wrote: > PTAL. lgtm, although for the numeric range stuff maybe ...
4 years, 6 months ago (2016-06-10 00:56:56 UTC) #6
rwlbuis
On 2016/06/10 00:56:56, Timothy Loh wrote: > On 2016/06/09 23:40:50, rwlbuis wrote: > > PTAL. ...
4 years, 6 months ago (2016-06-10 13:06:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056593005/20001
4 years, 6 months ago (2016-06-10 13:07:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 17:14:28 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 17:14:38 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 17:15:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c190d0749ed473cdd9dea6c29181336306c9308
Cr-Commit-Position: refs/heads/master@{#399215}

Powered by Google App Engine
This is Rietveld 408576698