third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 2056593005: Move more helper methods out of CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 2056593005: Move more helper methods out of CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: V2 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index b8f3ee3f1e266b0470129c91b784261d45141f7e..f2d605ace2f22aa36e96bdc3e6b679f12ab85551 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -47,10 +47,6 @@ public:

// Parses a non-shorthand CSS property

static CSSValue* parseSingleValue(CSSPropertyID, const CSSParserTokenRange&, const CSSParserContext&);

- // TODO(timloh): This doesn't seem like the right place for these

- static bool isSystemColor(CSSValueID);

- static bool isValidNumericValue(double);

private:

CSSPropertyParser(const CSSParserTokenRange&, const CSSParserContext&,

HeapVector<CSSProperty, 256>*);