Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/clang/value_cleanup/tests/list-value-append-original.cc

Issue 2056573002: value_cleanup: fixup ListValue::Append() calls that already have a unique_ptr to use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/value_cleanup/tests/list-value-append-original.cc
diff --git a/tools/clang/value_cleanup/tests/list-value-append-original.cc b/tools/clang/value_cleanup/tests/list-value-append-original.cc
index 02d74b937ca54adbb23dee71b163fae5fb73ba8a..bb9ee0305d5fcdb63800d9f302ebc18a391b07b9 100644
--- a/tools/clang/value_cleanup/tests/list-value-append-original.cc
+++ b/tools/clang/value_cleanup/tests/list-value-append-original.cc
@@ -2,10 +2,16 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <memory>
+
#include "base/values.h"
#define true true
+std::unique_ptr<base::Value> ReturnsUniquePtr() {
+ return nullptr;
+}
+
void F() {
base::ListValue list;
list.Append(new base::FundamentalValue(1 == 0));
@@ -13,4 +19,8 @@ void F() {
list.Append(new base::FundamentalValue(static_cast<unsigned char>(1.0)));
list.Append(new base::FundamentalValue(double{3}));
list.Append(new base::StringValue("abc"));
+
+ list.Append(ReturnsUniquePtr().release());
+ std::unique_ptr<base::Value> unique_ptr_var;
+ list.Append(unique_ptr_var.release());
vmpstr 2016/06/09 00:15:59 Can you add another test? It probably works :P st
dcheng 2016/06/09 00:57:13 Done.
}

Powered by Google App Engine
This is Rietveld 408576698