Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: tools/clang/value_cleanup/tests/list-value-append-original.cc

Issue 2056573002: value_cleanup: fixup ListValue::Append() calls that already have a unique_ptr to use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory>
6
5 #include "base/values.h" 7 #include "base/values.h"
6 8
7 #define true true 9 #define true true
8 10
11 std::unique_ptr<base::Value> ReturnsUniquePtr() {
12 return nullptr;
13 }
14
9 void F() { 15 void F() {
10 base::ListValue list; 16 base::ListValue list;
11 list.Append(new base::FundamentalValue(1 == 0)); 17 list.Append(new base::FundamentalValue(1 == 0));
12 list.Append(new base::FundamentalValue(true)); 18 list.Append(new base::FundamentalValue(true));
13 list.Append(new base::FundamentalValue(static_cast<unsigned char>(1.0))); 19 list.Append(new base::FundamentalValue(static_cast<unsigned char>(1.0)));
14 list.Append(new base::FundamentalValue(double{3})); 20 list.Append(new base::FundamentalValue(double{3}));
15 list.Append(new base::StringValue("abc")); 21 list.Append(new base::StringValue("abc"));
22
23 list.Append(ReturnsUniquePtr().release());
24 std::unique_ptr<base::Value> unique_ptr_var;
25 list.Append(unique_ptr_var.release());
vmpstr 2016/06/09 00:15:59 Can you add another test? It probably works :P st
dcheng 2016/06/09 00:57:13 Done.
16 } 26 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698