Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2056153003: value_cleanup: Rewrite more base::ListValue::Append(base::Value*) calls. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

value_cleanup: Rewrite more base::ListValue::Append(base::Value*) calls. The tool now understands how to rewrite simple cases of constructing a new base::Value that's stored in a raw pointer, manipulating it to populate the data, and then passing ownership into base::ListValue with the raw pointer overload of base::ListValue::Append. BUG=581865 Committed: https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40 Cr-Commit-Position: refs/heads/master@{#399319}

Patch Set 1 #

Patch Set 2 : Fix init #

Patch Set 3 : . #

Patch Set 4 : Delete debugging build flags #

Patch Set 5 : Handles auto as well now #

Total comments: 9

Patch Set 6 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -5 lines) Patch
M tools/clang/value_cleanup/ListValueRewriter.h View 1 2 3 chunks +16 lines, -1 line 0 comments Download
M tools/clang/value_cleanup/ListValueRewriter.cpp View 1 2 3 4 5 4 chunks +238 lines, -4 lines 0 comments Download
M tools/clang/value_cleanup/tests/list-value-append-expected.cc View 1 2 3 4 5 2 chunks +77 lines, -0 lines 0 comments Download
M tools/clang/value_cleanup/tests/list-value-append-original.cc View 1 2 3 4 5 2 chunks +77 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
dcheng
Auto not being deduced is weird, but everything else works great.
4 years, 6 months ago (2016-06-10 16:42:47 UTC) #2
dcheng
Fixed auto deduction now! The difference is using VarDecl::getTypeSourceInfo()->getType() vs using VarDecl::getType(). The former gives ...
4 years, 6 months ago (2016-06-10 19:32:44 UTC) #3
dcheng
On 2016/06/10 19:32:44, dcheng wrote: > Fixed auto deduction now! > > The difference is ...
4 years, 6 months ago (2016-06-10 19:33:01 UTC) #4
danakj
https://codereview.chromium.org/2056153003/diff/80001/tools/clang/value_cleanup/ListValueRewriter.cpp File tools/clang/value_cleanup/ListValueRewriter.cpp (right): https://codereview.chromium.org/2056153003/diff/80001/tools/clang/value_cleanup/ListValueRewriter.cpp#newcode167 tools/clang/value_cleanup/ListValueRewriter.cpp:167: class CollectDeclRefExprVisitor move this out of the method i ...
4 years, 6 months ago (2016-06-10 21:59:55 UTC) #5
dcheng
https://codereview.chromium.org/2056153003/diff/80001/tools/clang/value_cleanup/ListValueRewriter.cpp File tools/clang/value_cleanup/ListValueRewriter.cpp (right): https://codereview.chromium.org/2056153003/diff/80001/tools/clang/value_cleanup/ListValueRewriter.cpp#newcode167 tools/clang/value_cleanup/ListValueRewriter.cpp:167: class CollectDeclRefExprVisitor On 2016/06/10 21:59:55, danakj wrote: > move ...
4 years, 6 months ago (2016-06-10 22:39:43 UTC) #6
danakj
LGTM
4 years, 6 months ago (2016-06-10 22:42:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056153003/100001
4 years, 6 months ago (2016-06-10 22:49:28 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-10 23:43:30 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 23:43:37 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 23:45:18 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4ad61d2a7998735245a7f86d8b21def472453d40
Cr-Commit-Position: refs/heads/master@{#399319}

Powered by Google App Engine
This is Rietveld 408576698