Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Issue 2056043002: [css-flexbox] Cache whether our main axis size is definite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 // This is used to cache the preferred size for orthogonal flow children so we don't have to relayout to get it 193 // This is used to cache the preferred size for orthogonal flow children so we don't have to relayout to get it
194 HashMap<const LayoutObject*, LayoutUnit> m_intrinsicSizeAlongMainAxis; 194 HashMap<const LayoutObject*, LayoutUnit> m_intrinsicSizeAlongMainAxis;
195 195
196 // This set is used to keep track of which children we laid out in this curr ent layout iteration. 196 // This set is used to keep track of which children we laid out in this curr ent layout iteration.
197 // We need it because the ones in this set may need an additional layout pas s for correct stretch alignment 197 // We need it because the ones in this set may need an additional layout pas s for correct stretch alignment
198 // handling, as the first layout likely did not use the correct value for pe rcentage sizing of children. 198 // handling, as the first layout likely did not use the correct value for pe rcentage sizing of children.
199 HashSet<const LayoutObject*> m_relaidOutChildren; 199 HashSet<const LayoutObject*> m_relaidOutChildren;
200 200
201 mutable OrderIterator m_orderIterator; 201 mutable OrderIterator m_orderIterator;
202 int m_numberOfInFlowChildrenOnFirstLine; 202 int m_numberOfInFlowChildrenOnFirstLine;
203
204 // This is set to 0/1 during layout and -1 otherwise.
205 int m_hasDefiniteHeight = -1;
eae 2016/07/06 23:06:09 Use an enum for this. You might also want to pack
203 }; 206 };
204 207
205 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox()); 208 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox());
206 209
207 } // namespace blink 210 } // namespace blink
208 211
209 #endif // LayoutFlexibleBox_h 212 #endif // LayoutFlexibleBox_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698