Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2056033002: Clean Up Remaining Domain Check Call and netapi32.lib Usage (Closed)

Created:
4 years, 6 months ago by robliao
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@isos
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean Up Remaining Domain Check Call and netapi32.lib Usage BUG=none Committed: https://crrev.com/8245b2d002001ae27d0eb4159237557a2abd2262 Cr-Commit-Position: refs/heads/master@{#399574}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 3 chunks +3 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056033002/20001
4 years, 6 months ago (2016-06-10 18:52:26 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 21:20:56 UTC) #6
robliao
OWNERs, please review the path patterns under your e-mail address. Thanks! sky@chromium.org: chrome/chrome_browser.gypi scottmg@chromium.org: build/common.gypi ...
4 years, 6 months ago (2016-06-10 21:43:40 UTC) #9
scottmg
build lgtm
4 years, 6 months ago (2016-06-10 22:04:09 UTC) #10
pastarmovj
policy lgtm
4 years, 6 months ago (2016-06-13 08:01:24 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056033002/20001
4 years, 6 months ago (2016-06-13 17:06:24 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 18:49:55 UTC) #15
robliao
Looks like sky is OOO. Redirect to thestig. thestig: Please review changes in chrome/chrome_browser.gypi Thanks!
4 years, 6 months ago (2016-06-13 22:10:19 UTC) #17
Lei Zhang
rs lgtm based on scottmg's approve.
4 years, 6 months ago (2016-06-13 22:14:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056033002/20001
4 years, 6 months ago (2016-06-13 22:15:32 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-13 22:21:04 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 22:21:06 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 22:23:15 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8245b2d002001ae27d0eb4159237557a2abd2262
Cr-Commit-Position: refs/heads/master@{#399574}

Powered by Google App Engine
This is Rietveld 408576698