Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2048083003: Use IsOS(OS_DOMAINMEMBER) to Check for Domain Membership (Closed)

Created:
4 years, 6 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
Nico, pastarmovj, scottmg
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, pastarmovj, Roger Tawa OOO till Jul 10th
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use IsOS(OS_DOMAINMEMBER) to Check for Domain Membership The IsOS check and the NetGetJoinInformation check are equivalent. BUG=579196 Committed: https://crrev.com/4d1fae2deb4a053c1e572e036b7a9b033136e945 Cr-Commit-Position: refs/heads/master@{#399019}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove Newly Unused netapi32.lib Dependency from base #

Total comments: 2

Patch Set 3 : Remove the '!!' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M base/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/win/win_util.cc View 1 2 3 chunks +3 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 49 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048083003/1
4 years, 6 months ago (2016-06-09 16:15:40 UTC) #2
robliao
scottmg: Please review this CL. Thanks!
4 years, 6 months ago (2016-06-09 16:43:40 UTC) #4
grt (UTC plus 2)
https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc#newcode529 base/win/win_util.cc:529: !!IsOS(OS_DOMAINMEMBER) ? is there a benefit to doing this? ...
4 years, 6 months ago (2016-06-09 16:51:41 UTC) #6
scottmg
Add bug=579196. There's some concern on the original CL about it likely being a sync ...
4 years, 6 months ago (2016-06-09 16:55:32 UTC) #8
robliao
https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc#newcode529 base/win/win_util.cc:529: !!IsOS(OS_DOMAINMEMBER) ? On 2016/06/09 16:51:41, grt (slow) wrote: > ...
4 years, 6 months ago (2016-06-09 16:56:10 UTC) #9
scottmg
https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc File base/win/win_util.cc (left): https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc#oldcode530 base/win/win_util.cc:530: if(::NetGetJoinInformation(NULL, &domain, &join_status) != NERR_Success) From a quick skim, ...
4 years, 6 months ago (2016-06-09 17:12:15 UTC) #11
robliao
On 2016/06/09 16:55:32, scottmg wrote: > Add bug=579196. > > There's some concern on the ...
4 years, 6 months ago (2016-06-09 17:15:46 UTC) #12
grt (UTC plus 2)
Sounds like you two have this covered. I'll bow out. Thanks!
4 years, 6 months ago (2016-06-09 17:18:25 UTC) #13
scottmg
On 2016/06/09 17:18:25, grt (slow) wrote: > Sounds like you two have this covered. I'll ...
4 years, 6 months ago (2016-06-09 17:20:58 UTC) #14
scottmg
+pastarmovj just fyi
4 years, 6 months ago (2016-06-09 17:21:29 UTC) #15
robliao
On 2016/06/09 17:20:58, scottmg wrote: > On 2016/06/09 17:18:25, grt (slow) wrote: > > Sounds ...
4 years, 6 months ago (2016-06-09 17:25:02 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 17:55:47 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048083003/40001
4 years, 6 months ago (2016-06-09 18:51:42 UTC) #21
robliao
thakis@chromium.org: Please review the netapi32.lib removal in base/BUILD.gn Thanks! https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc File base/win/win_util.cc (left): https://codereview.chromium.org/2048083003/diff/1/base/win/win_util.cc#oldcode530 base/win/win_util.cc:530: ...
4 years, 6 months ago (2016-06-09 18:51:53 UTC) #23
scottmg
thanks, lgtm
4 years, 6 months ago (2016-06-09 18:54:33 UTC) #24
Nico
https://codereview.chromium.org/2048083003/diff/40001/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/2048083003/diff/40001/base/win/win_util.cc#newcode529 base/win/win_util.cc:529: !!IsOS(OS_DOMAINMEMBER) ? the interwebs claim IsOS returns a BOOL ...
4 years, 6 months ago (2016-06-09 19:15:10 UTC) #25
Nico
gn change lgtm though (needed in gyp too?)
4 years, 6 months ago (2016-06-09 19:15:49 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/226266)
4 years, 6 months ago (2016-06-09 19:34:22 UTC) #28
robliao
https://codereview.chromium.org/2048083003/diff/40001/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/2048083003/diff/40001/base/win/win_util.cc#newcode529 base/win/win_util.cc:529: !!IsOS(OS_DOMAINMEMBER) ? On 2016/06/09 19:15:10, Nico wrote: > the ...
4 years, 6 months ago (2016-06-09 19:43:36 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048083003/80001
4 years, 6 months ago (2016-06-09 19:44:11 UTC) #32
Nico
lgtm
4 years, 6 months ago (2016-06-09 19:48:58 UTC) #33
robliao
On 2016/06/09 19:15:49, Nico wrote: > gn change lgtm though (needed in gyp too?) ...and ...
4 years, 6 months ago (2016-06-09 19:53:40 UTC) #34
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 20:56:14 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048083003/80001
4 years, 6 months ago (2016-06-09 21:18:12 UTC) #39
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 6 months ago (2016-06-09 21:29:48 UTC) #41
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4d1fae2deb4a053c1e572e036b7a9b033136e945 Cr-Commit-Position: refs/heads/master@{#399019}
4 years, 6 months ago (2016-06-09 21:31:31 UTC) #43
grt (UTC plus 2)
On 2016/06/09 17:15:46, robliao wrote: > On 2016/06/09 16:55:32, scottmg wrote: > > Add bug=579196. ...
3 years, 7 months ago (2017-05-02 21:02:57 UTC) #44
robliao
On 2017/05/02 21:02:57, grt (UTC plus 2) wrote: > On 2016/06/09 17:15:46, robliao wrote: > ...
3 years, 7 months ago (2017-05-03 14:39:46 UTC) #45
grt (UTC plus 2)
On 2017/05/03 14:39:46, robliao wrote: > On 2017/05/02 21:02:57, grt (UTC plus 2) wrote: > ...
3 years, 7 months ago (2017-05-05 20:33:11 UTC) #46
robliao
On 2017/05/05 20:33:11, grt (UTC plus 2) wrote: > On 2017/05/03 14:39:46, robliao wrote: > ...
3 years, 7 months ago (2017-05-05 21:16:47 UTC) #47
pastarmovj
3 years, 7 months ago (2017-05-08 07:23:54 UTC) #49
Message was sent while issue was closed.
+Roger who recently did thorough analysis of the various ways to check AD vs MDM
joining.

Powered by Google App Engine
This is Rietveld 408576698