Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2055933002: [Mac/GN] Write PkgInfo files for .app bundles. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Write PkgInfo files for .app bundles. BUG=431177 R=sdefresne@chromium.org Committed: https://crrev.com/5c425ca31d354abef69b785a6ddba6360a82651c Cr-Commit-Position: refs/heads/master@{#399166}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M build/config/mac/rules.gni View 3 chunks +31 lines, -0 lines 0 comments Download
A build/config/mac/write_pkg_info.py View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Robert Sesek
4 years, 6 months ago (2016-06-09 20:56:48 UTC) #2
sdefresne
lgtm
4 years, 6 months ago (2016-06-10 08:33:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055933002/20001
4 years, 6 months ago (2016-06-10 11:57:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-10 13:01:51 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 13:03:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c425ca31d354abef69b785a6ddba6360a82651c
Cr-Commit-Position: refs/heads/master@{#399166}

Powered by Google App Engine
This is Rietveld 408576698