Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: remoting/host/chromoting_host_unittest.cc

Issue 205583011: [Draft] Fix canceling pin prompt causes host overload (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedbacks from sergey Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/chromoting_host_unittest.cc
diff --git a/remoting/host/chromoting_host_unittest.cc b/remoting/host/chromoting_host_unittest.cc
index 1410371a9bc8b5049461e0246697020ac5377808..d713b388b5c14420645a3f4cda98c3704642b6f2 100644
--- a/remoting/host/chromoting_host_unittest.cc
+++ b/remoting/host/chromoting_host_unittest.cc
@@ -595,22 +595,15 @@ TEST_F(ChromotingHostTest, IncomingSessionAccepted) {
TEST_F(ChromotingHostTest, IncomingSessionOverload) {
ExpectHostAndSessionManagerStart();
- EXPECT_CALL(*session_unowned1_, candidate_config()).WillOnce(Return(
- default_candidate_config_.get()));
- EXPECT_CALL(*session_unowned1_, set_config(_));
- EXPECT_CALL(*session_unowned1_, Close()).WillOnce(InvokeWithoutArgs(
- this, &ChromotingHostTest::NotifyConnectionClosed));
- EXPECT_CALL(host_status_observer_, OnAccessDenied(_));
EXPECT_CALL(host_status_observer_, OnShutdown());
host_->Start(xmpp_login_);
protocol::SessionManager::IncomingSessionResponse response =
protocol::SessionManager::DECLINE;
- host_->OnIncomingSession(session_unowned1_.release(), &response);
- EXPECT_EQ(protocol::SessionManager::ACCEPT, response);
- host_->OnIncomingSession(session_unowned2_.get(), &response);
+ host_->OnSessionAuthenticating(NULL);
Sergey Ulanov 2014/03/26 01:49:16 This test will break when OnSessionAuthenticating(
kelvinp 2014/03/27 03:23:21 Done.
+ host_->OnIncomingSession(session_unowned1_.get(), &response);
EXPECT_EQ(protocol::SessionManager::OVERLOAD, response);
ShutdownHost();

Powered by Google App Engine
This is Rietveld 408576698