[Draft] Fix canceling pin prompt causes host overload

remoting/host/chromoting_host.cc

Index: remoting/host/chromoting_host.cc
diff --git a/remoting/host/chromoting_host.cc b/remoting/host/chromoting_host.cc
index e4bdae75990a3a93c2c1ac8229ee2ceb544ee95b..80ab1ac3918a0a137b34fd250b77d80749d38131 100644
--- a/remoting/host/chromoting_host.cc
+++ b/remoting/host/chromoting_host.cc
@@ -171,6 +171,14 @@ void ChromotingHost::SetMaximumSessionDuration(
 
 ////////////////////////////////////////////////////////////////////////////
 // protocol::ClientSession::EventHandler implementation.
+void ChromotingHost::OnSessionAuthenticating(ClientSession* client) {

[Sergey Ulanov, 2014/03/27 00:00:03]

Looking more at this code I think we should move the
login_backoff_.ShouldRejectRequest() here in case there are multiple
simultaneous connection attempts.

[kelvinp, 2014/03/27 03:23:21]

Done.

+  // We treat each incoming connection as a failure to authenticate,
+  // and clear the backoff when a connection successfully
+  // authenticates. This allows the backoff to protect from parallel
+  // connection attempts as well as sequential ones.
+  login_backoff_.InformOfRequest(false);
+}
+
 bool ChromotingHost::OnSessionAuthenticated(ClientSession* client) {
   DCHECK(CalledOnValidThread());
 
@@ -265,16 +273,12 @@ void ChromotingHost::OnIncomingSession(
   }
 
   if (login_backoff_.ShouldRejectRequest()) {
+    LOG(WARNING) << "Rejecting connection due to"
+                    " an overload of failed login attempts.";
     *response = protocol::SessionManager::OVERLOAD;
     return;
   }
 
-  // We treat each incoming connection as a failure to authenticate,
-  // and clear the backoff when a connection successfully
-  // authenticates. This allows the backoff to protect from parallel
-  // connection attempts as well as sequential ones.
-  login_backoff_.InformOfRequest(false);
-
   protocol::SessionConfig config;
   if (!protocol_config_->Select(session->candidate_config(), &config)) {
     LOG(WARNING) << "Rejecting connection from " << session->jid()