Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2055733002: Clean up script-tests in css3/filters (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
davve
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up script-tests in css3/filters Rewrite the parsing tests using css-parser/resources/property-parsing-test.js and also use testharness for the computed style test. Drop css3/filters/filter-property.html since that is already covered by the wider parsing tests. Also remove the template html file and inline the scripts for effect-reference-reset-style-delete-crash.html [1] and effect-reference-delete-crash.html, clearing out the script-tests sub- directory. [1] This test was actually referencing the effect-reference-delete-crash.js file, meaning it was a duplicate. BUG=618607 Committed: https://crrev.com/88fb78b89bcb21f7b11388cb3ea5edd3125b2a46 Cr-Commit-Position: refs/heads/master@{#399136}

Patch Set 1 #

Patch Set 2 : Fix expectations for un-duped test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -1348 lines) Patch
M third_party/WebKit/LayoutTests/css3/filters/effect-reference-delete-crash.html View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-reference-reset-style-delete-crash.html View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/effect-reference-reset-style-delete-crash-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/filter-property.html View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/filter-property-computed-style.html View 1 chunk +107 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/filter-property-computed-style-expected.txt View 1 chunk +0 lines, -204 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/filter-property-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing.html View 1 chunk +97 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing-expected.txt View 1 chunk +0 lines, -394 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing-invalid.html View 1 chunk +82 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing-invalid-expected.txt View 1 chunk +0 lines, -329 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/script-tests/TEMPLATE.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/script-tests/effect-reference-delete-crash.js View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/script-tests/effect-reference-reset-style-delete-crash.js View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property.js View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-computed-style.js View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing.js View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/filters/script-tests/filter-property-parsing-invalid.js View 1 chunk +0 lines, -100 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
fs
Mostly mechanical changes and removals. No modifications to test data.
4 years, 6 months ago (2016-06-09 14:00:01 UTC) #3
davve
lgtm
4 years, 6 months ago (2016-06-10 07:08:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055733002/20001
4 years, 6 months ago (2016-06-10 07:39:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 08:29:29 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 08:29:34 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 08:31:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88fb78b89bcb21f7b11388cb3ea5edd3125b2a46
Cr-Commit-Position: refs/heads/master@{#399136}

Powered by Google App Engine
This is Rietveld 408576698