Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2052883002: Clamp filter functions {grayscale, invert, opacity, sepia} to 100% (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@filter-js-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp filter functions {grayscale, invert, opacity, sepia} to 100% The spec says the following for these functions: "Values of amount over 100% are allowed but UAs must clamp the values to 1." So do that rather than failing. This matches the behavior of Gecko and Edge. This fixes http://test.csswg.org/suites/filters-1_dev/nightly-unstable/html/filter-grayscale-005.htm from the CSS WG Filter Effects testsuite (w/ the property unprefixed.) BUG=618607 Committed: https://crrev.com/2fd3378f869dd3f9b5564d1e9ae96a0691126356 Cr-Commit-Position: refs/heads/master@{#399144}

Patch Set 1 #

Patch Set 2 : Additional test fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/css3/calc/number-parsing.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing.html View 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing-invalid.html View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
fs
4 years, 6 months ago (2016-06-09 20:29:39 UTC) #4
Timothy Loh
On 2016/06/09 20:29:39, fs wrote: lgtm
4 years, 6 months ago (2016-06-09 23:26:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052883002/20001
4 years, 6 months ago (2016-06-10 08:33:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 09:44:00 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 09:45:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fd3378f869dd3f9b5564d1e9ae96a0691126356
Cr-Commit-Position: refs/heads/master@{#399144}

Powered by Google App Engine
This is Rietveld 408576698