Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently

components/autofill/content/renderer/autofill_agent.h

Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index 0de9b5cb8138344a034f76c4e3a07040940ba77f..952207391d67cc4c64fcf52e821074782abadfe7 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -24,6 +24,10 @@
 #include "third_party/WebKit/public/web/WebFormElement.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 
+namespace {
+class MockAutofillAgent;
+}
+
 namespace blink {
 class WebNode;
 class WebView;
@@ -60,6 +64,8 @@ class AutofillAgent : public content::RenderFrameObserver,
   void BindRequest(mojom::AutofillAgentRequest request);
 
  private:
+  friend class ::MockAutofillAgent;

[vabr (Chromium), 2016/06/22 05:50:35]

Instead of the friend declaration, could you make the didAssociateFormControls a
protected method in AutofillAgent?

Once the friend declaration is there, the code is prone to mess up testing with
implementation details, which leads to fragile tests.

[keishi, 2016/06/22 08:27:35]

Done.

+
   // Functor used as a simplified comparison function for FormData. Only
   // compares forms at a high level (notably name, origin, action).
   struct FormDataCompare {