Add delay to didAssociateFormControlsTimer so it doesn't fire too frequently

components/autofill/content/renderer/autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
 
 #include <set>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "components/autofill/content/public/interfaces/autofill_agent.mojom.h"
 #include "components/autofill/content/public/interfaces/autofill_driver.mojom.h"
 #include "components/autofill/content/renderer/form_cache.h"
 #include "components/autofill/content/renderer/page_click_listener.h"
 #include "content/public/renderer/render_frame_observer.h"
 #include "content/public/renderer/render_view_observer.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 #include "third_party/WebKit/public/web/WebAutofillClient.h"
 #include "third_party/WebKit/public/web/WebFormControlElement.h"
 #include "third_party/WebKit/public/web/WebFormElement.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 
+namespace {
+class MockAutofillAgent;
+}
+
 namespace blink {
 class WebNode;
 class WebView;
 }
 
 namespace autofill {
 
 struct FormData;
 struct FormFieldData;
 struct PasswordFormFillData;
@@ skipping 16 matching lines @@
   // PasswordGenerationAgent may be NULL. If it is not, then it is also
   // guaranteed to outlive AutofillAgent.
   AutofillAgent(content::RenderFrame* render_frame,
                 PasswordAutofillAgent* password_autofill_manager,
                 PasswordGenerationAgent* password_generation_agent);
   ~AutofillAgent() override;
 
   void BindRequest(mojom::AutofillAgentRequest request);
 
  private:
+  friend class ::MockAutofillAgent;

[vabr (Chromium), 2016/06/22 05:50:35]

Instead of the friend declaration, could you make the didAssociateFormControls a
protected method in AutofillAgent?

Once the friend declaration is there, the code is prone to mess up testing with
implementation details, which leads to fragile tests.

[keishi, 2016/06/22 08:27:35]

Done.

+
   // Functor used as a simplified comparison function for FormData. Only
   // compares forms at a high level (notably name, origin, action).
   struct FormDataCompare {
     bool operator()(const FormData& lhs, const FormData& rhs) const;
   };
 
   // Thunk class for RenderViewObserver methods that haven't yet been migrated
   // to RenderFrameObserver. Should eventually be removed.
   // http://crbug.com/433486
   class LegacyAutofillAgent : public content::RenderViewObserver {
@@ skipping 221 matching lines @@
   mojom::AutofillDriverPtr mojo_autofill_driver_;
 
   base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_